Skip to content

Commit

Permalink
Disable TestPoolBackgroundChecksMinConns on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
jackc committed Jul 20, 2023
1 parent 2506cf3 commit 88b49d4
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pgxpool/pool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"errors"
"fmt"
"os"
"runtime"
"sync/atomic"
"testing"
"time"
Expand Down Expand Up @@ -586,6 +587,12 @@ func TestPoolBackgroundChecksMaxConnIdleTime(t *testing.T) {
}

func TestPoolBackgroundChecksMinConns(t *testing.T) {
// jackc: I don't have a good way to investigate this as I don't develop on Windows. Problem started with
// c513e2e435dca8acde76a4a0ed4856b9946b14e0, but I have no idea how. Help wanted. Test disabled on Windows for now.
if runtime.GOOS == "windows" {
t.Skip("Test always runs for 10m and is killed on CI. See https://github.com/jackc/pgx/issues/1690")
}

ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second)
defer cancel()

Expand Down

0 comments on commit 88b49d4

Please sign in to comment.