Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestPoolBackgroundChecksMinConns and NewConnsCount #1693

Merged
merged 1 commit into from
Jul 22, 2023

Commits on Jul 20, 2023

  1. fix TestPoolBackgroundChecksMinConns and NewConnsCount

    Previously it was checking TotalConns but that includes ConstructingConns.
    Instead it should directly check IdleConns so the next Acquire takes one of
    those and doesn't make a 3rd connection. The check against the context was
    also wrong which prevented this from timing out after 2 minutes.
    
    This also fixes a bug where NewConnsCount was not correctly counting
    connections created by Acquire directly.
    
    Fixes jackc#1690
    jameshartig committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    8dde39d View commit details
    Browse the repository at this point in the history