Use Go 1.20's link syntax for ParseConfig
#1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekSi
commented
Jul 27, 2023
| pool, err := pgxpool.New(context.Background(), os.Getenv("DATABASE_URL")) | ||
| The database connection string can be in URL or DSN format. PostgreSQL settings, pgx settings, and pool settings can be | ||
| specified here. In addition, a config struct can be created by `ParseConfig` and modified before establishing the | ||
| connection with `ConnectConfig`. | ||
| specified here. In addition, a config struct can be created by [ParseConfig]. |
There was a problem hiding this comment.
There is no ConnectConfig in pgxpool, so I removed it there and in other places in this package
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://golang.org/doc/comment#doclinks. I find myself looking for URL query parameters way too often. Links should help me and, hopefully, others.