Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PostgreSQL protocol for deallocating prepared statements #1797

Merged
merged 6 commits into from
Nov 18, 2023

Conversation

jackc
Copy link
Owner

@jackc jackc commented Nov 11, 2023

This allows Deallocate to succeed even inside of an aborted transaction.

It also only removes the connection's record of a prepared statement if the deallocation succeeds.

This should resolve the issue identified in #1795 and may also resolve #1791.

This method uses the PostgreSQL protocol Close method to deallocate a
prepared statement. This means that it can succeed in an aborted
transaction.
This uses the PostgreSQL protocol to deallocate a prepared statement
instead of a SQL statement. This allows it to work even in an aborted
transaction.
@jackc jackc merged commit 9103457 into master Nov 18, 2023
16 checks passed
@jackc jackc deleted the extended-protocol-deallocate branch November 18, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New prepared Statement scheme might be causing errors like: expected 0 arguments, got 2
1 participant