Batch.Queue: document always uses the conn's DefaultQueryExecMode #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way to change the query mode used by Batch.Queue and SendBatch is to use a connection with a different DefaultQueryExecMode. Add this to the function documentation. Conn.SendBatch: Move where mode is defined to make this clearer in the code. I spent time looking for the option that does not exist.
|
Good to have it documented more clearly. If we did want to be able to control the execution mode per batch then that probably could be implemented via an additional field on the pgx.Batch struct fairly easily. |
|
Sounds great thank you. Right now I'm just experimenting with this, and haven't needed to change the execution mode. If I do, I'll submit a PR. Thanks as always for the fast response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way to change the query mode used by Batch.Queue and SendBatch is to use a connection with a different
DefaultQueryExecMode. Add this to the function documentation.
Conn.SendBatch: Move where mode is defined to make this clearer in the code. I spent time looking for the option that does not exist.