Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Rows.Close() #1960

Closed

Conversation

bbaktaeho
Copy link

Hi, I frequently use the CollectOneRow function and noticed that Close() is redundantly called. There's no issue if it's already closed, but please remove it for cleaner code.

@jackc
Copy link
Owner

jackc commented Apr 13, 2024

That Close() is required.

The code above only reads a single row. If the result set had more than one row then rows.Err() would be returned before the deferred rows.Close(). This would be incorrect.

@jackc jackc closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants