fix(random): refactor alpha function to resolve failing test

jackfiszr · Dec 19, 2024 · 128e0e3 · 128e0e3
1 parent e6df171
commit 128e0e3
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/random.ts b/lib/random.ts
@@ -272,17 +272,19 @@ class Random {
       upcase?: boolean;
     } | number,
   ): string => {
-    if (typeof options === "number") options = { count: options };
+    // Extract options with safe defaults
+    const { count = 1, upcase = false } = typeof options === "number"
+      ? { count: options }
+      : options || {};
 
-    options = options || { count: 1, upcase: false };
     const letters = "abcdefghijklmnopqrstuvwxyz";
     let wholeString = "";
 
-    for (let i = 0; i < options.count!; i++) {
+    for (let i = 0; i < count; i++) {
       wholeString += this.faker.random.arrayElement(letters.split(""));
     }
 
-    return options.upcase ? wholeString.toUpperCase() : wholeString;
+    return upcase ? wholeString.toUpperCase() : wholeString;
   };
 
   /**