Fix pnp#1075

Improves handling custom sort order by checking for empty values. Also fixes a typo in a comment :)
jackpoz · Oct 26, 2024 · b2c1547 · b2c1547
1 parent 2252a61
commit b2c1547
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectTermGroups.cs b/src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectTermGroups.cs
@@ -311,9 +311,8 @@ from m in termGroup.GroupManagerPrincipalNames
                 {
                     var sortOrder = customSortOrder.Split(new[] { ':' }).ToList();
 
-                    var currentTermIndex = sortOrder.Where(i => new Guid(i) == term.Id).FirstOrDefault();
+                    var currentTermIndex = sortOrder.Where(i => !String.IsNullOrEmpty(i) && new Guid(i) == term.Id).FirstOrDefault();
                     modelTerm.CustomSortOrder = sortOrder.IndexOf(currentTermIndex) + 1;
-
                 }
             }
             termsToReturn = termsToReturn.OrderBy(t => t.CustomSortOrder).ToList();

diff --git a/src/lib/PnP.Framework/Provisioning/Providers/Xml/PnPObjectsMapper.cs b/src/lib/PnP.Framework/Provisioning/Providers/Xml/PnPObjectsMapper.cs
@@ -218,7 +218,7 @@ public static void MapProperties(Object source, Object destination, Dictionary<S
                         catch (Exception)
                         {
                             // Right now, for testing purposes, I just output and skip any issue
-                            // TODO: Handle issues insteaf of skipping them, we need to find a common pattern
+                            // TODO: Handle issues instead of skipping them, we need to find a common pattern
                         }
                     }
                 }