Phase 2a: Fix commands and vacuum diagnostic #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the diagnose→fix→verify loop for database remediation: Vacuum diagnostic (pgcrate vacuum): - Table bloat analysis using pg_stat_user_tables - Optional pgstattuple integration for accurate measurements - Thresholds: warning at 10%, critical at 25% or 1M dead tuples Fix commands: - pgcrate fix sequence: Upgrade sequence types (smallint→int→bigint) - pgcrate fix index --drop: Safely drop unused indexes (CONCURRENTLY) - pgcrate fix vacuum: Run VACUUM with options (freeze, full, analyze) Gate system for safety: - --read-write: Required for all fixes - --primary: Required for DB-modifying operations - --yes: Required for medium/high risk operations Verification runner: - Post-fix validation via JSONPath conditions - Runs diagnostic commands and checks expected results Triage enhancements: - --include-fixes flag generates structured fix actions - Actions include SQL preview, evidence, gates, and verify steps Enhanced index evidence: - stats_since, stats_age_days for usage confidence - is_replica_identity, backing_constraint for safety checks
Tests cover: - fix sequence: dry-run, gates, JSON output, downgrade blocking - fix index: dry-run, primary key blocking, JSON output - fix vacuum: dry-run, FULL requires --yes, JSON output - vacuum diagnostic: JSON structure - triage --include-fixes: actions array present
README.md: - Add vacuum to diagnostics section - Add Fix Commands section with examples - Update Commands table CHANGELOG.md: - Document Phase 2a features under Unreleased llms.txt: - Add DIAGNOSTICS section with health check commands - Add Fix Commands section with gate flags and risk levels - Update JSON supported commands list
Review fixes: - Replace duplicate quote_ident with crate::sql::quote_ident (safer always-quoting version) - Extract common print_fix_result helper to fix/common.rs - Remove unused parameters from get_verify_steps functions - Add execution test that verifies sequence upgrade works - Add tests for special identifiers (reserved words, quoted names) Net reduction of ~90 lines while adding 3 new tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the diagnose → fix → verify workflow for pgcrate:
pgcrate fix sequence- Upgrade sequence types (smallint → integer → bigint) to prevent exhaustionpgcrate fix index --drop- Safely drop unused/duplicate indexes with comprehensive safety checkspgcrate fix vacuum- Trigger vacuum operations (regular, freeze, full, analyze)pgcrate vacuum- New diagnostic for vacuum/bloat healthpgcrate triage --include-fixes- Get structured fix recommendations in triage outputSafety Model
All fix commands follow a gate system:
--read-writerequired for any mutations--primaryrequired to confirm connection to primary--yesrequired for medium/high risk operations (DROP INDEX, VACUUM FULL)Risk Levels
Key Files
src/commands/fix/- Fix command implementationssrc/commands/vacuum.rs- Vacuum diagnosticsrc/commands/triage.rs- Enhanced with--include-fixestests/diagnostics/fix.rs- 16 integration testsTest plan
cargo fmt --checkpassescargo clippy -- -D warningspasses