Skip to content

Conversation

@jackschultz
Copy link
Owner

Summary

Addresses issues identified from agent feedback analysis (106 feedback items).

Bug Fixes

  • BUG-4: Fix triage sequences rounding to match sequences command (use round(..., 2) consistently)

Note: BUG-1, BUG-2, BUG-3 were already fixed in commit 9e8dcbd (2026-01-18)

UX Improvements

  • UX-1: Add --show-sql flag to pgcrate dba triage to display SQL queries being run
  • UX-2: Already implemented (command aliases: migration→migrate, create→new)
  • UX-3: Already implemented (--allow-write implies --read-write)

Files Changed

  • src/commands/triage.rs - Add print_triage_queries() function, fix rounding
  • src/main.rs - Add --show-sql flag to Triage command
  • studio/discussions/2026-01-19-bug-fixes-ux-improvements.md - Mark all items resolved

Test plan

  • cargo test --bins passes (391 tests)
  • pgcrate dba triage --help shows new --show-sql flag
  • Build succeeds

- Change triage query to use round(..., 2)::float8 matching sequences.rs
- Update bug discussion file to reflect already-fixed bugs
Bug fixes:
- Fix triage sequences rounding to match sequences command (2 decimal places)

UX improvements:
- Add --show-sql flag to triage command to display SQL queries being run
- Update discussion doc to reflect already-implemented features:
  - Command aliases (migration→migrate, create→new) were already in place
  - --allow-write already implies --read-write

All items from studio/discussions/2026-01-19-bug-fixes-ux-improvements.md resolved.
- describe → inspect table
- triage, sequences, locks, etc. → dba triage, dba sequences, dba locks, etc.
- doctor → dba doctor

All diagnostic commands now use the dba namespace.
- describe → inspect table
- triage, sequences, locks, etc. → dba triage, dba sequences, dba locks, etc.
- doctor → dba doctor
- fix → dba fix

All diagnostic and fix commands now use the dba namespace.
@jackschultz jackschultz force-pushed the fix/v0.4.1-bug-fixes-ux branch from 169b7bd to caed5f7 Compare January 20, 2026 02:07
@jackschultz jackschultz merged commit b698e4c into main Jan 20, 2026
8 checks passed
@jackschultz jackschultz deleted the fix/v0.4.1-bug-fixes-ux branch January 20, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants