Made changes to support multiple vaults in Obsidian MCP Server plugin#20
Made changes to support multiple vaults in Obsidian MCP Server plugin#20mbelinky wants to merge 2 commits intojacksteamdev:mainfrom
Conversation
✅ Deploy Preview for superb-starlight-b5acb5 canceled.
|
There was a problem hiding this comment.
Thanks for making this PR! Multiple vault support will be vaulable for lots of people. These changes are a step in the right direction.
I have two concerns with this PR as-is:
-
I wasn't able to get this PR working on my computer. I'm not sure what's wrong, but I created
vaults.jsonand configured MCP_VAULTS_CONFIG_PATH inclaude_desktop_config.json. -
I think the installation UX for multiple vaults will probably frustrate typical non-technical users.
One of the main goals for an Obsidian plugin is to require little-to-no manual setup. Users should be able to click a button in the options page, and everything is done automatically, or at least through the UI.
This PR introduces a vaults.json file, which makes sense from a developer perspective, but we need to make it accessible to non-technical users, which means creating vaults.json automatically and guiding them through the process of adding vaults.
I know people want multiple vault support, and I really appreciate the time and effort this feature required, but I can't merge this PR without improvements to the user experience.
I've made changes to your code to accept multiple vaults.