Apostrophe fix #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grViz needs apostrophes to be in HTML. Escaping them won't work either, as they are replaced with " as part of the function.
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 82.18% 83.19% +1.00%
==========================================
Files 2 2
Lines 247 238 -9
==========================================
- Hits 203 198 -5
+ Misses 44 40 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug which prevented using apostrophes in custom labels.
DiagrammeR::grVizdoes not accept'in labels and escaping them won't work, because they get replaced with"in the process.This fix replaces apostrophes (
') in custom labels with HTML’.