Skip to content

Modify check_output to explicitly pass the errors object to is_valid_rij_list #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregfaletto wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Modify check_output to explicitly pass the errors object to is_valid_rij_list #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1521be0
Modify check_output to explicitly pass the errors object to is_valid_…
gregfaletto May 19, 2023
d3ee541
Avoid passing errors
jacobbien May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions R/output-class.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
is_valid_rij_list <- function(out, index) {
errs <- c()
if (length(out) < 1) {
errors <- c(errors, "out must be nonempty.")
errs <- c(errs, "out must be nonempty.")
} else {
str <- "incorrectly named elements of out. See documentation."
# should be of format ri.j where i is in index and j starts at 1.
pattern <- "^r([[:digit:]]+)[.]([[:digit:]]+)$"
i <- as.numeric(gsub(pattern, "\\1", names(out)))
j <- as.numeric(gsub(pattern, "\\2", names(out)))
if (any(is.na(i))) errors <- c(errors, str)
if (any(is.na(i))) errs <- c(errs, str)
if (any(sort(unique(i)) != sort(index)))
errors <- c(errors, "index does not match elements in out list.")
errs <- c(errs, "index does not match elements in out list.")
}
if (!all(unlist(lapply(out, is.list))))
errors <- c(errors, "out$ri.j should be a list.")
errs <- c(errs, "out$ri.j should be a list.")
nams <- lapply(out, function(r) names(r))
if (!all(unlist(lapply(nams, function(nam) identical(nam, nams[[1]])))))
errors <- c(errors, "all out$ri.j must have same elements.")
errs <- c(errs, "all out$ri.j must have same elements.")
}

check_output <- function(object) {
Expand Down