Fixed an issue when IEEE floating-point rounding mode is IEEE_DOWN #545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue when IEEE floating-point rounding mode is manually set to
IEEE_DOWN
.The original code in the
string_to_integer
subroutineerroneously returns 1 even when
ndigits
is 10 (while the correct value should be 2).The following code is the minimum reproducible example of the problem.
The last
deserialize
will result in a crush.I assume simply changing
floor
tonint
should solve the issue without any side effects.