Proposed Fix for #602 #603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed fix sets target standard to f08 to match the rest of the build methods.
…allocation error found in test 48. 2MB was not sufficient. Further investigation could potentially identify a more precise target, but this should be sufficient to also have room for future increases in memory usage in testing. jacobwilliams#602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should address the stack size issue identified in #602 by increasing the stack reservation. 3MB was found to be sufficient to pass, 2 MB was not. A further investigation could allow a more precise target, but keeping it slightly higher allows for increases in memory usage before problems.