Skip to content
This repository was archived by the owner on Apr 28, 2022. It is now read-only.

Set trace id via SpanBuilder #60

Closed
wants to merge 2 commits into from
Closed

Set trace id via SpanBuilder #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df62ebd
Set trace id via SpanBuilder (`WithTraceId(...)`)
Marfusios May 16, 2018
4ea2812
Sign off
Marfusios May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Jaeger.Core/SpanBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ internal class SpanBuilder : ISpanBuilder

private DateTime? _startTimestampUtc;
private List<Reference> _references;
private TraceId? _traceId;
private bool _ignoreActiveSpan;

internal SpanBuilder(Tracer tracer, string operationName)
Expand Down Expand Up @@ -82,6 +83,12 @@ public ISpanBuilder WithStartTimestamp(DateTimeOffset startTimestamp)
return this;
}

public ISpanBuilder WithTraceId(TraceId traceId)
{
_traceId = traceId;
return this;
}

public ISpanBuilder IgnoreActiveSpan()
{
_ignoreActiveSpan = true;
Expand Down Expand Up @@ -135,7 +142,7 @@ public ISpan Start()

private SpanContext CreateNewContext(string debugId)
{
TraceId traceId = TraceId.NewUniqueId();
TraceId traceId = _traceId ?? TraceId.NewUniqueId();
SpanId spanId = new SpanId(traceId);

var flags = SpanContextFlags.None;
Expand Down
15 changes: 15 additions & 0 deletions test/Jaeger.Core.Tests/SpanBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,21 @@ public void SpanBuilder_WithTag_ShouldSetTags()
Assert.Equal("string, yo", tags["stringkey"]);
}

[Fact]
public void SpanBuilder_WithTraceId_ShouldSetTraceId()
{
var tracer = GetTracer();
var providedTraceId = new TraceId(42, 33);

var builder = (SpanBuilder)tracer.BuildSpan("foo");
var span = (Span)builder
.WithTraceId(providedTraceId)
.Start();

var usedTraceId = span.Context.TraceId;
Assert.Equal(providedTraceId, usedTraceId);
}

[Fact]
public void SpanBuilder_AsChildOf_IgnoresNullSpan()
{
Expand Down