Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Searchbar in FAQ's and fixed the Navbar issue- Unexpected Navbar #182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sandeepmaddheshiya
Copy link

You can view the issue: #177

Changes Made

  • Added Search bar to FAQ's Section

After making changes:

Recording.2024-10-21.221753.mp4

Note: This changes doesn't disturbs the previous functionalities.

Copy link

vercel bot commented Oct 21, 2024

@sandeepmaddheshiya is attempting to deploy a commit to the jahnvi sahni's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@jahnvisahni31
Copy link
Owner

Conflicting files
app/front-navbar.tsx

@sandeepmaddheshiya
Copy link
Author

Ok I'll resolve it by EOD.

Copy link
Author

@sandeepmaddheshiya sandeepmaddheshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved Conflicts.
@jahnvisahni31 please check.

If still occurs then please accept changes made in faq/page.tsx file.
Thank you!

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-deck ❌ Failed (Inspect) Oct 26, 2024 7:14am

@jahnvisahni31
Copy link
Owner

image
error

@sandeepmaddheshiya
Copy link
Author

sandeepmaddheshiya commented Oct 26, 2024

@jahnvisahni31 yeah i was also facing the same issue that's why i've changed it but due to conflicts i've revert that changes in front-navbar

@jahnvisahni31
Copy link
Owner

someone has also get the changes approved

@sandeepmaddheshiya
Copy link
Author

It was already in the main , so i reverted to the main (due to conflicts)

@jahnvisahni31
Copy link
Owner

This branch has conflicts that must be resolved
Use the web editor or the to resolve conflicts.
Conflicting files
app/faq/page.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants