Begin decoupling listing logic from model list implementation (#2289) #2
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # SPDX-License-Identifier: Apache-2.0 | |
| name: E2E (NVIDIA Tesla T4 x1) | |
| on: | |
| # run against every merge commit to 'main' and release branches | |
| push: | |
| branches: | |
| - main | |
| - release-* | |
| # only run on PRs that touch certain regex paths | |
| pull_request_target: | |
| branches: | |
| - main | |
| - release-* | |
| paths: | |
| # note this should match the merging criteria in 'mergify.yml' | |
| - '**.py' | |
| - 'pyproject.toml' | |
| - 'requirements**.txt' | |
| - 'scripts/basic-workflow-tests.sh' # Used by this workflow | |
| - 'scripts/test-data/**' | |
| - '.github/workflows/e2e-nvidia-t4-x1.yml' # This workflow | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.number || github.ref }} | |
| cancel-in-progress: true | |
| env: | |
| LC_ALL: en_US.UTF-8 | |
| defaults: | |
| run: | |
| shell: bash | |
| permissions: | |
| contents: read | |
| jobs: | |
| e2e-workflow-ready: | |
| permissions: | |
| checks: read | |
| uses: ./.github/workflows/status-checks.yml | |
| with: | |
| job_ids: >- # Space-separated job ids to wait on for status checks | |
| DCO | |
| actionlint | |
| markdown-lint | |
| shellcheck | |
| spellcheck | |
| lint-workflow-complete | |
| start-ec2-runner: | |
| needs: | |
| - e2e-workflow-ready | |
| runs-on: ubuntu-latest | |
| outputs: | |
| label: ${{ steps.start-ec2-runner.outputs.label }} | |
| ec2-instance-id: ${{ steps.start-ec2-runner.outputs.ec2-instance-id }} | |
| steps: | |
| - name: Configure AWS credentials | |
| uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2 | |
| with: | |
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | |
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | |
| aws-region: ${{ secrets.AWS_REGION }} | |
| - name: Start EC2 runner | |
| id: start-ec2-runner | |
| uses: machulav/ec2-github-runner@fcfb31a5760dad1314a64a0e172b78ec6fc8a17e # v2.3.6 | |
| with: | |
| mode: start | |
| github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }} | |
| ec2-image-id: ami-01a89eee1adde309c | |
| ec2-instance-type: g4dn.2xlarge | |
| subnet-id: subnet-02d230cffd9385bd4 | |
| security-group-id: sg-06300447c4a5fbef3 | |
| iam-role-name: instructlab-ci-runner | |
| aws-resource-tags: > | |
| [ | |
| {"Key": "Name", "Value": "instructlab-ci-github-small-runner"}, | |
| {"Key": "GitHubRepository", "Value": "${{ github.repository }}"}, | |
| {"Key": "GitHubRef", "Value": "${{ github.ref }}"}, | |
| {"Key": "GitHubPR", "Value": "${{ github.event.number }}"} | |
| ] | |
| e2e-test: | |
| needs: | |
| - start-ec2-runner | |
| runs-on: ${{ needs.start-ec2-runner.outputs.label }} | |
| # It is important that this job has no write permissions and has | |
| # no access to any secrets. This part (e2e-test) is where we are running | |
| # untrusted code from PRs. | |
| permissions: {} | |
| steps: | |
| - name: Install Packages | |
| run: | | |
| cat /etc/os-release | |
| sudo dnf install -y gcc gcc-c++ make git python3.11 python3.11-devel | |
| - name: Checkout | |
| uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 | |
| with: | |
| # https://github.com/actions/checkout/issues/249 | |
| fetch-depth: 0 | |
| - name: Fetch and checkout PR | |
| if: ${{ github.event_name == 'pull_request_target' }} | |
| run: | | |
| git fetch origin pull/${{ github.event.number }}/head:pr-${{ github.event.number }} | |
| git checkout pr-${{ github.event.number }} | |
| - name: Install ilab | |
| run: | | |
| export PATH="/home/ec2-user/.local/bin:/usr/local/cuda/bin:$PATH" | |
| python3.11 -m venv --upgrade-deps venv | |
| . venv/bin/activate | |
| nvidia-smi | |
| python3.11 -m pip cache remove llama_cpp_python | |
| CMAKE_ARGS="-DLLAMA_CUDA=on" python3.11 -m pip install . | |
| # https://github.com/instructlab/instructlab/issues/1821 | |
| # install with Torch and build dependencies installed | |
| python3.11 -m pip install packaging wheel setuptools-scm | |
| python3.11 -m pip install .[cuda] | |
| - name: Check disk | |
| run: | | |
| df -h | |
| - name: Run e2e test | |
| run: | | |
| . venv/bin/activate | |
| ./scripts/basic-workflow-tests.sh -msq | |
| stop-ec2-runner: | |
| needs: | |
| - start-ec2-runner | |
| - e2e-test | |
| runs-on: ubuntu-latest | |
| if: ${{ always() }} | |
| steps: | |
| - name: Configure AWS credentials | |
| uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2 | |
| with: | |
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | |
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | |
| aws-region: ${{ secrets.AWS_REGION }} | |
| - name: Stop EC2 runner | |
| uses: machulav/ec2-github-runner@fcfb31a5760dad1314a64a0e172b78ec6fc8a17e # v2.3.6 | |
| with: | |
| mode: stop | |
| github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }} | |
| label: ${{ needs.start-ec2-runner.outputs.label }} | |
| ec2-instance-id: ${{ needs.start-ec2-runner.outputs.ec2-instance-id }} | |
| e2e-workflow-complete: | |
| # we don't want to block PRs on failed EC2 cleanup | |
| # so not requiring "stop-ec2-runner" as well | |
| permissions: | |
| checks: read | |
| uses: ./.github/workflows/status-checks.yml | |
| with: | |
| job_ids: >- # Space-separated job ids to wait on for status checks | |
| e2e-workflow-ready | |
| start-ec2-runner | |
| e2e-test |