Formatting and distro detection for setup.sh #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `echo` escapes control characters such as `\n`, which leads to an output like this a\nb instead of this a b By using `echo -e` those characters are not escaped anymore, and don't yield ugly `\n` outputs instead of actual newlines. Signed-off-by: Dorian Stoll <dorian.stoll@tmsp.io>
Since the official packages are offered as .deb packages, it doesn't make much sense to offer installing them on a pacman-based, or rpm-based distribution. Instead, the package manager is detected dynamically (i.e. if dpkg is found you can install .deb, if pacman is found you can install .pkg.tar.xz etc.), and the apropreate source for kernel / libwacom packages is linked. It might be possible to install them automatically as well, but some distributions might require custom setup so it is probably safer to only offer autoinstall for the upstream packages. Signed-off-by: Dorian Stoll <dorian.stoll@tmsp.io>
This tries to group the outputs more into logical blocks as opposed to just having newlines everywhere, therefor making the output more understandable Signed-off-by: Dorian Stoll <dorian.stoll@tmsp.io>
|
These changes have been combined into #548. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the setup script outputs something like this:
This is because
echoby default interprets the\ncharacter literally. To make it print an actual newline,echo -ehas to be used. I also tried to rearrange the newlines to structure the output into some kind of blocks (i.e. suspend vs. hibernate is it's own block, replacing default config is it's own block, etc.)The other change is that the script dynamically detects the package manager of the distribution (
dpkgfor Debian based systems,pacmanfor Arch) and points at the supported sources for patched kernels and libwacom (this repository for Debian, dmhackers repository for Arch that is linked in the README).If no supported package manager was found, it advises the user to compile the kernel themselves.
The full output of the changed script then looks like this: https://gist.github.com/StollD/a4429098b989901f039e29034dd9e003