Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recent-calls single call record pull #343

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

recent-calls single call record pull #343

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c178df0
recent-calls single call record pull
surajshivkumar Aug 17, 2024
cc0f836
recent-calls single call record pull
surajshivkumar Aug 19, 2024
9067dbc
recent-calls single call record pull
surajshivkumar Aug 19, 2024
2e51a2b
Merge branch 'main' into recentCalls-singleCallPull
surajshivkumar Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions lib/routes/api/recent-calls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,31 @@ router.get('/:call_sid/record/:year/:month/:day/:format', async(req, res) => {
}
});

router.get('/call/:call_sid', async(req, res) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have /Calls/:call_sid

const { account_sid, call_sid } = req.params;
const { logger, queryCdrs } = req.app.locals;

try {
logger.debug('GET /call/:call_sid');
const account_sid = parseAccountSid(req.originalUrl);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated account_sid

const data = await queryCdrs({
account_sid,
filter: call_sid,
page: 1,
page_size: 1
});

if (!data || data.data.length === 0) {
return res.status(404).json({ message: 'Call not found' });
}

res.status(200).json(data.data[0]);
} catch (err) {
logger.error({ err }, `Error retrieving call information for account_sid: ${account_sid}, call_sid: ${call_sid}`);
res.sendStatus(500);
}
});

router.delete('/:call_sid/record/:year/:month/:day/:format', async(req, res) => {
const {logger} = req.app.locals;
const {call_sid, year, month, day, format} = req.params;
Expand Down
Loading