Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add synth options call session #615

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Catharsis68
Copy link
Contributor

@Catharsis68 Catharsis68 commented Jan 16, 2024

@xquanluu this PR is based on PR #590

  • Add speechSynthesisOptions from config verb to a Call Session
  • In say task: if defined, apply the speechSynthesisOptions to this.options - but let them get overwritten by say.synthesizer.options

@davehorton
Copy link
Contributor

@xquanluu do you have an opinion on this PR?

@xquanluu
Copy link
Contributor

For me I don't know the issue related to this, but from the code, he wants to override say verb synthesizer options from config verb if say verb syntheizer.options is missing

@Catharsis68
Copy link
Contributor Author

Catharsis68 commented Feb 12, 2024

@xquanluu there is another PR #590 (which is not working) - the general issue was
"the config provides session-level settings, but if a verb specifies something different, that should take preference for that verb"

So a say node with synthesizer options should overwrite the general config.

This PR adds the synthesizerOptions to the call-session object in the config task. Otherwise it is never possible to access these options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants