Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support speechmatics speechcredential #458

Merged
merged 3 commits into from
Oct 11, 2024
Merged

support speechmatics speechcredential #458

merged 3 commits into from
Oct 11, 2024

Conversation

xquanluu
Copy link
Contributor

No description provided.

@davehorton
Copy link
Contributor

davehorton commented Oct 10, 2024

sorry @xquanluu we also need to store the url of the endpoint as it turns out.

On that page you can see there are currently 3 supported endpoints for their streaming api.

  • EU: eu2.rt.speechmatics.com (on demand)
  • EU: neu.rt.speechmatics.com (enterprise customers only)
  • US: wus.rt.speechmatics.com (enterprise customers only)

Let's have a region dropdown with those 3 choices, showing in the same way, e.g.

"EU: eu2.rt.speechmatics.com (on demand)"

as far as what we send to the api-server, send the URL only.

Also please put the 3 choices in some sort of data file or structure that will be easy to update in the future, as I am sure they will add new endpoints

@davehorton
Copy link
Contributor

actually, I notice they support on-prem as well. So I think we need

  • radio buttons for hosted or on-prem
  • when hosted selected, dropdown with the 3 URLs
  • when on-prem selected, simple input field for URL

plus api key regardless of above

@xquanluu
Copy link
Contributor Author

Screenshot 2024-10-11 at 11 08 11
Screenshot 2024-10-11 at 11 03 32

@davehorton
Copy link
Contributor

Looks good @xquanluu. One last request: could you add a variable to the .env called VITE_APP_DISABLE_ADDITIONAL_SPEECH_VENDORs and if set to true do not include speechmatics in the dropdown list.

@davehorton davehorton merged commit 7aaea04 into main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants