feat: make it PWA (progressive web app)#87
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements Progressive Web App (PWA) functionality by adding a web app manifest and linking it in the HTML head, addressing issue #58.
- Added a complete PWA manifest with app metadata and icon definitions
- Integrated the manifest into the site's meta tags for PWA recognition
Reviewed Changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| public/manifest.json | Defines PWA configuration including app name, theme colors, icons, and display settings |
| components/Meta.tsx | Links the manifest file in the HTML head for PWA functionality |
| {props.keywords && <meta name="keywords" content={props.keywords} />} | ||
| {props.author && <meta name="author" content={props.author} />} | ||
| {props.ogUrl && <meta property="og:url" content={props.ogUrl} />} | ||
| <link rel="manifest" href="../manifest.json" /> |
There was a problem hiding this comment.
The manifest path '../manifest.json' is incorrect. Since the manifest is in the public directory, it should be '/manifest.json' to reference it from the root of the public folder.
| <link rel="manifest" href="../manifest.json" /> | |
| <link rel="manifest" href="/manifest.json" /> |
|
@jucktnich Thank you! Welcome to the contributors list! I updated logo assets! |
|
@peckz Thanks for merging. Sadly the pwa-manifest is wrongly linked by me; do you want to link the manifest correctly, or should i provide a fix? |
|
@jucktnich actually manifest is good, we have a very complex proxy setup. If you wish to install this as PWA, please use this link https://jam-dev-utilities.pages.dev Also, it's probably worth adding this info to readme file |
2 participants
Hey,
I made the site a progressive web app by adding a
manifest.json, icons, and linking themanifest.jsonin themeta-tags. This PR solves issue #58. I'd love to get feedback on this, and if you determine it useful, I'd love to see it being merged into the main branch.