Migrate statement-position Vec<Expression> to Vec<ExpressionStatement> (BT-974)#1009
Merged
Migrate statement-position Vec<Expression> to Vec<ExpressionStatement> (BT-974)#1009
Conversation
…tement> (BT-974) Phase 1, Issue 2 of ADR 0044 (Comments as First-Class AST Nodes). - Change Module.expressions, MethodDefinition.body, Block.body from Vec<Expression> to Vec<ExpressionStatement> - Rename Module.leading_comments to Module.file_leading_comments - Update parser to wrap with ExpressionStatement::bare() - Update all codegen, lint, semantic, LSP, and query consumers - Regenerate 65 parser snapshots Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (65)
📒 Files selected for processing (44)
📝 WalkthroughWalkthroughThis PR introduces a new Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1, Issue 2 of ADR 0044 (Comments as First-Class AST Nodes). Pure mechanical type migration — no behavior changes.
Module.expressions,MethodDefinition.body,Block.body) fromVec<Expression>toVec<ExpressionStatement>Module.leading_commentstoModule.file_leading_commentsExpressionStatement::bare(), codegen/lint/semantic/LSP unwrap via.expressionLinear: https://linear.app/beamtalk/issue/BT-974
Test plan
just cipasses (build, clippy, fmt-check, test, test-e2e)🤖 Generated with Claude Code
Summary by CodeRabbit