Docs site: HTML comment fix, ADR generation, mobile responsiveness#1014
Docs site: HTML comment fix, ADR generation, mobile responsiveness#1014
Conversation
…eness Fix HTML comment stripping for pulldown-cmark 0.13 (multi-line HtmlBlock events), generate ADR pages with dedicated navigation sidebar, extract Tooling page from language-features.md, add class hierarchy summaries, simplify stdlib README, update CNAME to www.beamtalk.dev, and add responsive CSS for mobile with sidebar overlay tap-to-close. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds ADR (Architecture Decision Records) generation and integration into the docs site pipeline; strips HTML comments during markdown rendering; renders per-class first-line summaries in hierarchies; introduces a responsive sidebar overlay and CSS tweaks; adds new tooling docs; updates GitHub Pages CNAME to www.beamtalk.dev. Changes
Sequence DiagramsequenceDiagram
participant SiteGen as Site Generator
participant ADRDisc as ADR Discovery
participant ADRRender as ADR Renderer
participant ProseGen as Prose Generator
participant LinkRewrite as Link Rewriter
participant PageRender as Page Renderer
SiteGen->>ADRDisc: discover_adrs(adr_source)
ADRDisc->>ADRDisc: parse metadata (number, slug, title)
ADRDisc->>ADRRender: render_adr_page(adr)
ADRDisc->>ADRRender: render_adr_index(adrs)
ADRDisc-->>SiteGen: return adr_links
SiteGen->>ProseGen: generate_prose_docs(prose_pages, extra_links=adr_links)
ProseGen->>LinkRewrite: rewrite_prose_links(content, extra_links)
LinkRewrite-->>ProseGen: rewritten content
ProseGen->>PageRender: render prose pages (with ADR nav)
SiteGen->>PageRender: write_site_landing_page (include ADR cards)
PageRender-->>SiteGen: site generation complete
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
stdlib/src/README.md (1)
7-7: LGTM! Simplification aligns with the documentation overhaul.The minimal README appropriately directs users to per-class API pages, which aligns with the PR's broader documentation restructuring.
Optional enhancement for discoverability
Consider adding a link or brief navigation hint to help users locate the class pages, e.g.:
-See each class page for full API documentation and usage examples. +See the [class documentation](../docs/stdlib/) for full API documentation and usage examples.Or list a few key classes if navigation is not immediately obvious from the rendered site context.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@stdlib/src/README.md` at line 7, Update the README (stdlib/src/README.md) to include a short navigation hint or direct link(s) to the per-class API pages so users can find class documentation more easily; for example add a sentence like "See the API docs at <site-root>/stdlib or the class index" or list 3–5 key class pages (e.g., ClassA, ClassB, ClassC) to improve discoverability when the site context doesn't make navigation obvious.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@stdlib/src/README.md`:
- Line 7: Update the README (stdlib/src/README.md) to include a short navigation
hint or direct link(s) to the per-class API pages so users can find class
documentation more easily; for example add a sentence like "See the API docs at
<site-root>/stdlib or the class index" or list 3–5 key class pages (e.g.,
ClassA, ClassB, ClassC) to improve discoverability when the site context doesn't
make navigation obvious.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
.github/workflows/docs.ymlcrates/beamtalk-cli/src/commands/doc/assets.rscrates/beamtalk-cli/src/commands/doc/layout.rscrates/beamtalk-cli/src/commands/doc/mod.rscrates/beamtalk-cli/src/commands/doc/renderer.rscrates/beamtalk-cli/src/commands/doc/site.rsdocs/beamtalk-language-features.mddocs/beamtalk-tooling.mdstdlib/src/README.md
Summary
HtmlBlockevents are now collected and examined as a whole before deciding to dropdocs/ADR/*.mdwith dedicated sidebar navigation and index pagebeamtalk-tooling.mdwww.beamtalk.devTest plan
just testpasses (all Rust, stdlib, BUnit tests green)🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation