Fix doc comments: use /// and remove blank lines before class defs#1019
Merged
Fix doc comments: use /// and remove blank lines before class defs#1019
Conversation
…ions All example files used // instead of /// for class-level doc comments, and had blank lines between the comment block and the class definition. Both issues prevented doc comments from being attached to AST nodes (collect_doc_comment resets on blank lines and // comments). Also fixed 6 stdlib/src files (Boolean, ClassBuilder, False, True, TestResult, TestRunner) that had blank lines before their class definitions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (55)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.btfiles (49 files) that used//instead of///for class-level doc comments — doc comments were never being attached to AST nodescollect_doc_comment()resets on blank lines (>1 newline), silently dropping the commentstdlib/src/files (Boolean,ClassBuilder,False,True,TestResult,TestRunner) that had the blank line issue with existing///commentsTest plan
just test— 5038 tests passjust test-stdlib— 237 tests pass//→///and blank line removal, no content changesFollow-up
///doc comments (prevents this from recurring)🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
Documentation
New Features