Skip to content

Commit

Permalink
Fix broken OOP things in RageSoundReader_mp3
Browse files Browse the repository at this point in the history
nice going fission
  • Loading branch information
poco0317 committed Sep 21, 2019
1 parent 149cf04 commit 68d7161
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/RageUtil/Sound/RageSoundReader.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class RageSoundReader
virtual RageSoundReader* Copy() const = 0;
virtual int GetSampleRate() const = 0;
virtual unsigned GetNumChannels() const = 0;
virtual bool SetProperty(const RString& /* sProperty */, float /* fValue */)
virtual bool SetProperty(const RString& sProperty, float fValue)
{
return false;
}
Expand Down
4 changes: 2 additions & 2 deletions src/RageUtil/Sound/RageSoundReader_Extend.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "Etterna/Globals/global.h"
#include "Etterna/Globals/global.h"
#include "RageSoundReader_Extend.h"
#include "RageSoundUtil.h"
#include "RageUtil/Utils/RageUtil.h"
Expand Down Expand Up @@ -204,5 +204,5 @@ RageSoundReader_Extend::SetProperty(const RString& sProperty, float fValue)
return true;
}

return false;
return RageSoundReader_Filter::SetProperty(sProperty, fValue);
}
2 changes: 1 addition & 1 deletion src/RageUtil/Sound/RageSoundReader_MP3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ RageSoundReader_MP3::SetPosition(int iFrame)
}

bool
RageSoundReader_MP3::SetProperty(const std::string& sProperty, float fValue)
RageSoundReader_MP3::SetProperty(const RString& sProperty, float fValue)
{
if (sProperty == "AccurateSync") {
m_bAccurateSync = (fValue > 0.001f);
Expand Down
2 changes: 1 addition & 1 deletion src/RageUtil/Sound/RageSoundReader_MP3.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class RageSoundReader_MP3 : public RageSoundReader_FileReader
unsigned GetNumChannels() const { return Channels; }
int GetSampleRate() const { return SampleRate; }
int GetNextSourceFrame() const;
bool SetProperty(const std::string& sProperty, float fValue);
bool SetProperty(const RString& sProperty, float fValue) override;

RageSoundReader_MP3();
~RageSoundReader_MP3();
Expand Down

0 comments on commit 68d7161

Please sign in to comment.