Skip to content

Commit

Permalink
fix missedHold judgments never coming back in leaderboard requests
Browse files Browse the repository at this point in the history
wow (this fixes nothing. reminder to fix the usage of this for replay usage)
  • Loading branch information
poco0317 committed Sep 12, 2022
1 parent 4c72664 commit 70956b5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/Etterna/Singletons/DownloadManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1730,6 +1730,12 @@ DownloadManager::RequestChartLeaderBoard(const string& chartkey,
tmp.letgo = judgements["letGoHold"].GetInt();
else
tmp.letgo = 0;
if (judgements.HasMember("missedHold") &&
judgements["missedHold"].IsInt())
tmp.holdmiss = judgements["missedHold"].GetInt();
else
tmp.holdmiss = 0;

}
if (score.HasMember("datetime") && score["datetime"].IsString())
tmp.datetime.FromString(score["datetime"].GetString());
Expand Down Expand Up @@ -1821,6 +1827,7 @@ DownloadManager::RequestChartLeaderBoard(const string& chartkey,

hs.SetHoldNoteScore(HNS_Held, tmp.held);
hs.SetHoldNoteScore(HNS_LetGo, tmp.letgo);
hs.SetHoldNoteScore(HNS_Missed, tmp.holdmiss);

FOREACH_ENUM(Skillset, ss)
hs.SetSkillsetSSR(ss, tmp.SSRs[ss]);
Expand Down
1 change: 1 addition & 0 deletions src/Etterna/Singletons/DownloadManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ class OnlineScore
int marvelous{ 0 };
int minehits{ 0 };
int held{ 0 };
int holdmiss{ 0 };
std::string songId;
int letgo{ 0 };
bool valid{ false };
Expand Down

0 comments on commit 70956b5

Please sign in to comment.