Reduce CustomizeGameplay I/O impact by saving only on Screen Exit

jameskr97 · Nov 13, 2019 · 852cd31 · 852cd31
1 parent 7f1d23a
commit 852cd31
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Themes/Til Death/BGAnimations/ScreenGameplay overlay/messagebox.lua b/Themes/Til Death/BGAnimations/ScreenGameplay overlay/messagebox.lua
@@ -18,6 +18,10 @@ return Def.ActorFrame {
 		SCREENMAN:GetTopScreen():AddInputCallback(MovableInput)
 		self:SetUpdateFunction(highlight)
 	end,
+	OffCommand = function(self)
+		-- save CustomizeGameplay changes when leaving the screen
+		playerConfig:save(pn_to_profile_slot(PLAYER_1))
+	end,
 	Def.BitmapText {
 		Name = "message",
 		Font = "Common Normal",

diff --git a/Themes/Til Death/Scripts/02 CustomizeGameplay.lua b/Themes/Til Death/Scripts/02 CustomizeGameplay.lua
@@ -940,7 +940,10 @@ function MovableInput(event)
 			end
 			playerConfig:get_data(pn_to_profile_slot(PLAYER_1))[current.elementTree][keymode][prop] = newVal
 			playerConfig:set_dirty(pn_to_profile_slot(PLAYER_1))
-			playerConfig:save(pn_to_profile_slot(PLAYER_1))
+			-- commented this to save I/O time and reduce lag
+			-- just make sure to call this somewhere else to make sure stuff saves.
+			-- (like when the screen changes....)
+			--playerConfig:save(pn_to_profile_slot(PLAYER_1))
 		end
 	end
 	return false