rebirth actually fix misalignments for practice cdgraph

jameskr97 · Dec 23, 2022 · a400d33 · a400d33
1 parent 2b6ffd3
commit a400d33
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/Themes/Rebirth/BGAnimations/ScreenGameplay overlay/elements/_gameplaypractice.lua b/Themes/Rebirth/BGAnimations/ScreenGameplay overlay/elements/_gameplaypractice.lua
@@ -205,19 +205,16 @@ t[#t+1] = Def.Quad {
     Name = "BookmarkPos",
     InitCommand = function(self)
         -- trickery
-        self:SetFakeParent(self:GetParent():GetChild("PracticeCDGraph"))
-        self:playcommand("SetUpMovableValues")
         self:valign(0)
         self:zoomto(bookmarkWidth, height)
         self:diffuse(bookmarkColor)
         self:diffusealpha(bookmarkAlpha)
         self:draworder(1100)
         self:visible(false)
     end,
-    SetUpMovableValuesMessageCommand = function(self)
-        self:y(MovableValues.PracticeCDGraphY)
-        local height = MovableValues.PracticeCDGraphHeight * (53 / 555 * SCREEN_HEIGHT)
-        self:zoomy(height)
+    FirstUpdateCommand = function(self)
+        -- have to call this late because the graph is named late (in BeginCommand)
+        self:SetFakeParent(self:GetParent():GetChild("PracticeCDGraph"))
     end,
     SetCommand = function(self)
         self:visible(true)