move profile save to after score upload, so it is done before eval

jameskr97 · Jul 13, 2020 · c62833f · c62833f
1 parent 82b67dd
commit c62833f
Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Etterna/Models/Misc/StageStats.cpp b/src/Etterna/Models/Misc/StageStats.cpp
@@ -727,6 +727,10 @@ StageStats::FinalizeScores(bool bSummary)
 							 hs);
 	mostrecentscorekey = hs.GetScoreKey();
 	zzz->m_lastSong.FromSong(GAMESTATE->m_pCurSong);
+	if (m_bLivePlay) {
+		PROFILEMAN->SaveLocalProfile(
+		  PROFILEMAN->GetProfile(PLAYER_1)->m_sProfileID);
+	}
 
 	CHECKPOINT_M("Finished Finalizing Score");
 	LOG->Trace("done saving stats and high scores");

diff --git a/src/Etterna/Screen/Others/ScreenProfileSave.cpp b/src/Etterna/Screen/Others/ScreenProfileSave.cpp
@@ -22,11 +22,8 @@ ScreenProfileSave::Input(const InputEventPlus& input)
 void
 ScreenProfileSave::Continue()
 {
-	DLMAN->chartLeaderboards.clear(); // clear cached leaderboard scores when
-									  // saving after gameplay -mina
-	if (!STATSMAN->m_vPlayedStageStats.empty())
-		if (STATSMAN->m_vPlayedStageStats.back().m_bLivePlay)
-			GAMESTATE->SavePlayerProfiles();
+	// clear cached leaderboard scores after gameplay
+	DLMAN->chartLeaderboards.clear();
 
 	SCREENMAN->ZeroNextUpdate();