Prevent crash from trying to cache unrecognized stepstype

not the completely correct fix this may cause a song to have no steps in some situations
jameskr97 · Jul 6, 2020 · f4a698e · f4a698e
1 parent 282325f
commit f4a698e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/Etterna/Models/Songs/SongCacheIndex.cpp b/src/Etterna/Models/Songs/SongCacheIndex.cpp
@@ -549,6 +549,11 @@ SongCacheIndex::CacheSong(Song& song, const std::string& dir)
 		int64_t songID = sqlite3_last_insert_rowid(db->getHandle());
 		vector<Steps*> vpStepsToSave = song.GetStepsToSave();
 		for (auto steps : vpStepsToSave) {
+			if (steps->m_StepsType >= NUM_StepsType) {
+				LOG->Info("Not caching unrecognized stepstype in file %s",
+						  dir.c_str());
+				continue;
+			}
 			if (steps->GetChartKey() == "") { // Avoid writing cache tags for
 											  // invalid chartkey files(empty
 											  // steps) -Mina