feat: add hostname to notification #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgroschupp
force-pushed
the
message-on-host
branch
3 times, most recently
from
df2d6bf to
f883d20
Compare
cgroschupp
force-pushed
the
message-on-host
branch
from
f883d20 to
fe6472e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1318 +/- ##
===========================================
+ Coverage 73.60% 73.61% +0.01%
===========================================
Files 44 44
Lines 4152 4150 -2
===========================================
- Hits 3056 3055 -1
+ Misses 1096 1095 -1 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have several dedicated Simplemonitor instances running and since this change b4444ff#diff-2a27fb7a5900a5f0ac428b1ae3aaeda31fe5b7347f2c7729a60f9754f94be3f7L59 I can no longer distinguish the alarms.