test(monitor): mock file write for recovery tests #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jamesoff#1356 The tests for `did_recovery` and `did_recovered` touch a file that they leave around. While we could use a temporary file, in this context, it seems like mocking subprocess.Popen should be sufficient.
wyardley
force-pushed
the
wyardley/issue_1356
branch
from
74133e5 to
846597a
Compare
wyardley
commented
Feb 12, 2025
| # throws an exception if the file isn't there | ||
| os.stat("did_recovery") | ||
| # Make sure we called the fake command | ||
| mock_popen.assert_called_once_with(["touch", "did_recovery"]) |
There was a problem hiding this comment.
note: I kept the command and the arguments as they were. But since we're not calling it, this really could be anything (and could use more complex args if we want to make sure argument parsing / etc. is handled as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1356
The tests for
did_recoveryanddid_recoveredtouch a file that they leave around.While we could use a temporary file, in this context, it seems like mocking subprocess.Popen should be sufficient.