Fix sorting of numeric strings.

jameswilddev · Dec 1, 2021 · 62b6db4 · 62b6db4
1 parent b24257c
commit 62b6db4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/components/createCreatableSelectComponent/createCreatableSelectChildrenComponent/index.tsx b/components/createCreatableSelectComponent/createCreatableSelectChildrenComponent/index.tsx
@@ -142,7 +142,7 @@ export const createCreatableSelectChildrenComponent = <
     const normalizedFilter = normalize(filter);
 
     const sortedOptions = [...options].sort(({ label: a }, { label: b }) =>
-      a.localeCompare(b)
+      a.localeCompare(b, [], { numeric: true })
     );
 
     let filteredOptions;

diff --git a/components/createOfflineTableComponent/index.tsx b/components/createOfflineTableComponent/index.tsx
@@ -382,7 +382,9 @@ export const createOfflineTableComponent = <
         } else if ((fromB as unknown as boolean) === false) {
           comparisonResult = 1;
         } else {
-          comparisonResult = String(fromA).localeCompare(String(fromB));
+          comparisonResult = String(fromA).localeCompare(String(fromB), [], {
+            numeric: true,
+          });
         }
       }
 

diff --git a/...eateSearchableMultiSelectComponent/createSearchableMultiSelectChildrenComponent/index.tsx b/...eateSearchableMultiSelectComponent/createSearchableMultiSelectChildrenComponent/index.tsx
@@ -127,7 +127,7 @@ export const createSearchableMultiSelectChildrenComponent = <
     const normalizedFilter = normalize(filter);
 
     const sortedOptions = [...options].sort(({ label: a }, { label: b }) =>
-      a.localeCompare(b)
+      a.localeCompare(b, [], { numeric: true })
     );
 
     let filteredOptions;

diff --git a/components/createSearchableSelectComponent/createSearchableSelectChildrenComponent/index.tsx b/components/createSearchableSelectComponent/createSearchableSelectChildrenComponent/index.tsx
@@ -128,7 +128,7 @@ export const createSearchableSelectChildrenComponent = <
     const normalizedFilter = normalize(filter);
 
     const sortedOptions = [...options].sort(({ label: a }, { label: b }) =>
-      a.localeCompare(b)
+      a.localeCompare(b, [], { numeric: true })
     );
 
     let filteredOptions;