Show select items in a filtered multi select. This is inconsistent wi…

…th react-select but is less annoying to use.
jameswilddev · Nov 25, 2021 · 8be4894 · 8be4894
1 parent 16b9ad0
commit 8be4894
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...eateSearchableMultiSelectComponent/createSearchableMultiSelectChildrenComponent/index.tsx b/...eateSearchableMultiSelectComponent/createSearchableMultiSelectChildrenComponent/index.tsx
@@ -130,9 +130,8 @@ export const createSearchableMultiSelectChildrenComponent = <
     let filteredOptions;
 
     if (normalizedFilter) {
-      filteredOptions = sortedOptions.filter(
-        ({ label, value }) =>
-          !values.includes(value) && normalize(label).includes(normalizedFilter)
+      filteredOptions = sortedOptions.filter(({ label }) =>
+        normalize(label).includes(normalizedFilter)
       );
     } else {
       filteredOptions = sortedOptions;

diff --git a/...reateSearchableMultiSelectComponent/createSearchableMultiSelectChildrenComponent/unit.tsx b/...reateSearchableMultiSelectComponent/createSearchableMultiSelectChildrenComponent/unit.tsx
@@ -388,7 +388,7 @@ test(`renders as expected without a filter`, () => {
   expect(stub).not.toHaveBeenCalled();
 });
 
-test(`filters the list down to only those unselected and matching the user's input`, () => {
+test(`filters the list down to only those matching the user's input`, () => {
   const Component = createSearchableMultiSelectChildrenComponent<TestValue>({
     fontFamily: `Example Font Family`,
     fontSize: 37,