Randomize and adapt ping intervals in connection dialog to reduce correlation #3550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make sure that after the dialog is hidden all server get a ping soon, also distant ones, but still in a way that it is not regular pattern - use randomized timer interval of 1000-1250ms since the real interval is calculated internally by skipping, also changed this to be smooth scaled - cleanup the map stuff, just store this in the Qt::UserRole data - network address is costly, cache it in Qt::UserRole - renamed things a bit and cleanup
…e normal 2500ms ping interval otherwise the longer delay will be treated as a stop of ping, fPingMaxMultiplier is now 3.0 instead of 9.0, could be increased in the future...
- store all data in UserRole of first column, no need to have an invisible column, - added enum for userrole fields - detailed stats only in debug - some minor adjustments on timings
mcfnord
reviewed
Oct 25, 2025
| qDebug() << "\nPattern analysis:"; | ||
| qDebug() << " Average pings/sec:" << QString::number ( avgPingsPerSecond, 'f', 2 ); | ||
| qDebug() << " Spikes detected (>2x avg):" << iSpikesDetected << "seconds"; | ||
| qDebug() << " Distribution: " << ( iSpikesDetected > 10 ? "IRREGULAR (many spikes)" : "SMOOTH (good stealth)" ); |
There was a problem hiding this comment.
I set up a time-out when a burst of pings arrive from one IP:PORT, because I thought these were non-clients. Then my own client triggered the time-out for bursting pings. Seems odd for the client to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
To avoid correlation on client behaviour this change will randomize the ping intervals, adaptive to the ping time, nearer servers get pinged more often, distant ones less.
To avoid correlation of "hide connect dialog" (ping immediately stops) and "connected to a server" (user appears on a server) it will keep pinging for approx. 60 seconds after the dialog gets hidden.
In addition:
CHANGELOG: Randomized and adaptive ping intervals in connection dialog, keep ping running after some time after dialog gets closed.
Context: Fixes an issue?
See https://github.com/orgs/jamulussoftware/discussions/3545
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
What is missing until this pull request can be merged?
Unsure if the diagnostic code (currently only in debug builds) can/should be kept in.
Checklist