fix non-existent property onVolumeChanged

janbar · May 5, 2020 · 8930f85 · 8930f85
1 parent 6f213dc
commit 8930f85
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 27 deletions.
diff --git a/gui/components/RenderingControlerView.qml b/gui/components/RenderingControlerView.qml
@@ -133,9 +133,9 @@ MusicListView {
                     from: 0
                     to: 100
                     objectName: "volumeSliderShape"
-                    value: model.volume
                     enabled: !model.outputFixed
                     opacity: (model.outputFixed ? 0.2 : 1.0)
+                    value: model.volume
 
                     handleSize: (model.outputFixed ? 0 : units.gu(2))
                     handleColor: labelColor
@@ -186,19 +186,6 @@ MusicListView {
                             }
                         }
                     }
-
-                    Connections {
-                        target: model
-                        onVolumeChanged: {
-                            // update an icoming change when released only to be smoothest
-                            if (!volumeSlider.pressed)
-                                volumeSlider.value = model.volume > 0 ? model.volume : 0.0;
-                        }
-                    }
-
-                    Component.onCompleted: {
-                        value = model.volume > 0 ? model.volume : 0.0;
-                    }
                 }
 
                 /* Grip button */

diff --git a/gui/sfos/components/RenderingControlerView.qml b/gui/sfos/components/RenderingControlerView.qml
@@ -130,6 +130,7 @@ MusicListView {
                     animateValue: true
                     enabled: !model.outputFixed
                     opacity: (model.outputFixed ? 0.2 : 1.0)
+                    value: model.volume
 
                     onValueChanged: {
                         if (down)
@@ -160,19 +161,6 @@ MusicListView {
                             }
                         }
                     }
-
-                    Connections {
-                        target: model
-                        onVolumeChanged: {
-                            // update an icoming change when released only to be smoothest
-                            if (!volumeSlider.down)
-                                volumeSlider.value = model.value;
-                        }
-                    }
-
-                    Component.onCompleted: {
-                        value = model.volume;
-                    }
                 }
 
                 /* Grip button */