Skip to content

Comments

adding manage project linkage with SEALS#3

Open
mamun4105 wants to merge 7 commits intojandrewjohnson:mainfrom
mamun4105:main
Open

adding manage project linkage with SEALS#3
mamun4105 wants to merge 7 commits intojandrewjohnson:mainfrom
mamun4105:main

Conversation

@mamun4105
Copy link

Hi Justin,

I pulled the latest version you have and then pushed the newest edit I have. There is no conflict in the merge. All changes are handled by separate functions such that your existing functions do not change.

Key changes:

  1. Added a separate run file for manage: run_manage_standard.py
  2. Added a new function in seals_initialize_project.py. The function is named build_manage_run_task_tree(p)
  3. Added two new functions in seals_tasks.py. One function is named project_aoi_gtap_r251(p). It will filter AOI based on column 'gtapv7_r251_label'. As filtering based on this column can have more than 1 feature in Geodataframe, I added a slightly modified function from hb.extract_features_in_shapefile_by_attribute with conditional dissolving functionality. This function is named 'extract_features_in_shapefile_by_attribute_dissolve'.
  4. Added a script (scripts/es_model_functions.py) that runs both SDR and Pollination models.
  5. Added a local version of InVEST SDR model (scripts/sdr_local.py) which is lighter in computation. It does not compute unnecessary stuff.
  6. Added pollination sufficiency and pollination economic functions. scripts/pollination_biophysical_model.py is a replica of global_invest/ecosystem_services_functions.py but I deleted unused import and carbon calculation. I prefer it to be local here for MANAGE project. scripts/pollination_shocks.py estimates shocks for pollination.
  7. Added a folder named 'scripts/oneoffs'. This folder contains several files that are used to preprocess some input data for InVEST models. A general user does not need those. I am just keeping them here.

Thank you!
Saleh

These are one time use functions to prepare global level input dataset for various models.  A typical user does not need to use these functions as these inputs are in the base data folder
… shock

These functions estimates pollination sufficiency from a lulc and then compare the scenario lulc with baseline lulc to calculate shocks depending on the crop adjusted pollination dependence. These functions are not modified much other than making it homogenous such that it can take any scenario parameter provided by seals. Previously these functions were static only for 2017 baseline and 2022 scenario
This version of InVEST SDR is modified such that it has light computation compared to InVEST SDR model. I did not run the whole SDR model because we only use usle output from SDR.  Running a low computation version makes sense to save time.
…el as column name when filtering AOI

This version of the function make disputed lands to project AOI. I also added a local function that is similar to hb.extract_features_in_shapefile_by_attribute but it can dissolve features if the length of features is greater than 1. Later we may consider adding this fucntion directly yo hb.
…ice and economic implications are added in the pipeline
This test run is separated from standard seals test run. It take projected CRS as input. Projected CRS is critical for running invest models
@lingling-liu
Copy link

@jandrewjohnson I wanted to check if we should proceed with submitting this pull request to the main seals_dev repository, given that we're planning to create a standalone deliverable for the World Bank. Alternatively, should we focus on refining the SEALS_MANAGE_DEV repository (https://github.com/jandrewjohnson/seals_manage_dev) instead?

Looking forward to your guidance!

@jandrewjohnson
Copy link
Owner

jandrewjohnson commented Nov 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants