Fix an off-by-one :)

jank-lang · Feb 4, 2024 · 1317135 · 1317135
1 parent cde9a30
commit 1317135
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/include/cpp/jank/runtime/obj/symbol.hpp b/include/cpp/jank/runtime/obj/symbol.hpp
@@ -24,7 +24,7 @@ namespace jank::runtime
     static_object(native_persistent_string &&ns, native_persistent_string &&n);
     static_object(native_persistent_string const &ns,
                   native_persistent_string const &n,
-                  option<object_ptr> meta);
+                  object_ptr meta);
 
     static_object &operator=(static_object const &) = default;
     static_object &operator=(static_object &&) = default;

diff --git a/src/cpp/jank/codegen/processor.cpp b/src/cpp/jank/codegen/processor.cpp
@@ -1075,7 +1075,7 @@ namespace jank::codegen
     auto ret_tmp(runtime::context::unique_string("map"));
 
     /* Jump right to a hash map, if we have enough values. */
-    if(expr.data_exprs.size() < runtime::obj::persistent_array_map::max_size)
+    if(expr.data_exprs.size() <= runtime::obj::persistent_array_map::max_size)
     {
       fmt::format_to(inserter, "auto const {}(", ret_tmp);
       if(expr.meta.is_some())

diff --git a/src/cpp/jank/evaluate.cpp b/src/cpp/jank/evaluate.cpp
@@ -319,7 +319,7 @@ namespace jank::evaluate
                            analyze::expr::map<analyze::expression> const &expr)
   {
     auto const size(expr.data_exprs.size());
-    if(size < runtime::obj::persistent_array_map::max_size)
+    if(size <= runtime::obj::persistent_array_map::max_size)
     {
       auto const array_box(make_array_box<runtime::object_ptr>(size * 2));
       size_t i{};

diff --git a/src/cpp/jank/runtime/obj/symbol.cpp b/src/cpp/jank/runtime/obj/symbol.cpp
@@ -46,7 +46,7 @@ namespace jank::runtime
 
   obj::symbol::static_object(native_persistent_string const &ns,
                              native_persistent_string const &n,
-                             option<object_ptr> const meta)
+                             object_ptr const meta)
     : ns{ ns }
     , name{ n }
     , meta{ meta }