clojure.test

[frenchy64]

Workarounds noted in comment at the top of clojure/test.jank.

Needed clojure.core/ns-interns from clojure.core, but I had to add the function name to every (throw "TODO: port") statement to figure that out.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.37%. Comparing base (617968a) to head (f3ce443).
Report is 63 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   58.55%   58.37%   -0.19%     
==========================================
  Files         158      159       +1     
  Lines       19587    19936     +349     
==========================================
+ Hits        11470    11637     +167     
- Misses       8117     8299     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jeaye]

It's fine to change all of these, but it wasn't needed to find your error. For that, I'd just hop into gdb and tell it to stop when an exception is thrown.

gdb --args ./build/jank run foo.jank
> catch throw
> run
... wait for an exception to be thrown and gdb will stop ...
> backtrace
... see where you are ...

[frenchy64]

Aha, so (byte 1) will give #2 0x00007fffe8df885d in clojure_core_byte_3074_1 ().

Very instructive thanks.

[jeaye]

Not quite. clojure_core_byte_3074_1 means clojure.core/byte <gensym count> <arity 1>. This is for the function itself, not a call to it.

[frenchy64]

Ok. I pointed it out because AFAICT this is the only frame that gives a hint of which function needs implementing. Is there a way to configure source mapping? e.g.,

;;foo.jank
(ns foo)
(defn -main [] (byte 1)) 

#8  0x00007ffff33850e0 in foo.main_1_0 >>here>> at foo.jank:2 <<here<< ()

[jeaye]

There will be, but it's a large feature which involves a lot of LLVM IR work. Perhaps I know the right guy for it, though. I'll reach out to him.

[frenchy64]

Putting this back to draft actually, clojure.test/are doesn't work yet.

[frenchy64]

Opened and worked around #237

WDYT about the approach here of gradually adding the clojure-test suite? Just requires a deps.edn to be added to clojure-test: {:paths ["test"]}.

[jeaye]

Opened and worked around #237

WDYT about the approach here of gradually adding the clojure-test suite? Just requires a deps.edn to be added to clojure-test: {:paths ["test"]}.

I think we can gradually add for now, but note that the clojure-test suite is specifically designed to support missing vars. It will skip them. So, we should just #_ out our unimplemented defns and then run all tests.

Syntactically, I think the only thing we're missing is big number support. Will need to get someone on that.