Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return nil for clojure.core/namespace if unqualified #256

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Return nil for clojure.core/namespace if unqualified #256

merged 1 commit into from
Feb 11, 2025

Conversation

frenchy64
Copy link
Contributor

@frenchy64 frenchy64 commented Feb 10, 2025 •
edited
Loading

@frenchy64
Return nil for clojure.core/namespace if unqualified
deb3a35 
Unqualified includes "" namespace in jank, which is qualified in
Clojure.
@frenchy64 frenchy64 changed the title WIP: Return nil for clojure.core/namespace if unqualified Return nil for clojure.core/namespace if unqualified Feb 10, 2025
@frenchy64 frenchy64 marked this pull request as ready for review February 10, 2025 21:12
@jeaye jeaye merged commit 0c7a525 into jank-lang:main Feb 11, 2025
7 checks passed
@jeaye
Copy link
Member

jeaye commented Feb 11, 2025

Thanks, Ambrose!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

namespace should be nil for unqualified idents
2 participants
@frenchy64 @jeaye