Fix Niggli edge case failures in WBM symmetry analysis #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- eda_mp_trj.py replace matplotlib with Plotly for element count heatmaps and ratios - plot_structure_perturbation.py utilize Plotly for histogram and structure visualizations - wbm_umap_projection.py use Plotly for UMAP scatter plots, improving interactivity and aesthetics
janosh
force-pushed
the
fix-wbm-symmetries-2-failing-niggli-reduce
branch
from
bb5ec4b to
45fd5b0
Compare
- fix plot function signatures to reflect removal of matplotlib backend option, now only Plotly - remove last matplotlib vestiges from EDA scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #182. thanks for noticing and fixing @lan496 🚀
also remove last few remaining uses of
matplotlibin favor ofplotlyin EDA scripts