-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lightspeed): integrate lightspeed backend #2501
feat(lightspeed): integrate lightspeed backend #2501
Conversation
|
d14e505
to
067fe1b
Compare
067fe1b
to
b566dae
Compare
4a00065
to
d3edc1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good to me from backend perspective, just a comment regarding switch to use fetchApi
backstage provided.
otherthan that, I'm wondering if we should get a review from UX as well?
I noticed in the screen recording @karthikjeeyar uploaded. the model list takes a fairly long time to display for a new chat session. I'm wondering do we need to fetch the list upon every new session?
also the chat session shows after received the first AI response. I'm wondering if a session should be created once after a newconversation_id
has been generated and responded, even without any summary?
Yes, I have already shared the PR with April in our team channel and updated the PR based on her and Ben's comments, tagging @aprilma419 again for getting +1 in the PR
No, it is not fetched upon every new session, models are fetched only on initial load but conversations in sidebar loaded immediately as I have cached that request. I can add caching to the models fetch call as well, as it will not be frequently changing.
As we have discussed in the slack, summary will not be re-analyzed once it is created and stored in db right? so I am waiting for the first AI response to be complete to generate the summary at the end of first conversation between human and AI. |
d3edc1d
to
39e027e
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Fixes
https://issues.redhat.com/browse/RHDHPAI-26
https://issues.redhat.com/browse/RHDHPAI-38
Description
This PR replaces backstage proxy backend with lightspeed backend and supports following features:
Screenshots
Search results:
welcome prompt:
Video:
Lightspeed_demo.mov
How to test:
Unit tests: