fix(cli): add @mui/utils to the webpack singleton configuration #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-jerolimov
requested review from
davidfestal,
jesuino,
gashcrumb and
kadel
as code owners
🦋 Changeset detectedLatest commit: aeedcda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
webpack-make-mui-utils-singleton
branch
from
ca9f3ed to
aeedcda
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change looks a bit bigger because I extracted the configuration into a variable.
But actually, it just adds
@mui/utilsto the webpack federation configuration so that the app and the plugins share one version of that.This might resolve some MUI v5 issues... Not 100% sure...
Because Backstage configures the class name generator from
@mui/material/classNamelike this:https://github.com/backstage/backstage/blob/v1.35.0/packages/theme/src/unified/UnifiedThemeProvider.tsx#L49-L51
Which is then:
https://github.com/mui/material-ui/blob/v5.x/packages/mui-material/src/className/index.ts
=> https://github.com/mui/material-ui/blob/v5.x/packages/mui-utils/src/index.ts#L46
===> https://github.com/mui/material-ui/blob/v5.x/packages/mui-utils/src/ClassNameGenerator/ClassNameGenerator.ts