-
Notifications
You must be signed in to change notification settings - Fork 149
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(dynamic-plugins): make mountpoints and layout declarative
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
- Loading branch information
Showing
38 changed files
with
997 additions
and
1,043 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
--- | ||
'app': major | ||
--- | ||
|
||
Use dynamic frontend plugins across the app | ||
|
||
This change makes `dynamicPlugins.frontend.mountPoints` generic and declarative: | ||
|
||
Mountpoint now support following names/types: | ||
|
||
- Allow passing \*/context mountpoints for React context | ||
- Allow passing \*/cards for Card components (with layout) | ||
|
||
- `entity.page.overview` | ||
- `entity.page.topology` | ||
- `entity.page.issues` | ||
- `entity.page.pull-requests` | ||
- `entity.page.ci` | ||
- `entity.page.cd` | ||
- `entity.page.kubernetes` | ||
- `entity.page.tekton` | ||
- `entity.page.image-registry` | ||
- `entity.page.monitoring` | ||
- `entity.page.lighthouse` | ||
- `entity.page.api` | ||
- `entity.page.dependencies` | ||
- `entity.page.docs` | ||
- `entity.page.definition` | ||
- `entity.page.diagram` | ||
|
||
Mountpoints support following configuration: | ||
|
||
- `layout` for layout features that propagates to <Box sx=... /> allowing users to use CSS properties gridColumnStart including responsiveness queries etc. (mui.com/system/getting-started/the-sx-prop) | ||
- `if` for EntitySwitch.Case if=... - allows allOf|anyOf|oneOf conditionals with isKind|isType|hasAnnotation builtin methods or code imports via Scalprum (direct string reference) | ||
- `props` to pass additional props to the mounted component | ||
|
||
Current limitations of the dynamic frontend plugins: | ||
|
||
Allows you to mount to existing mountPoints only. You're unable to create additional tabs for example. (will be addressed in a follow up PR) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.