fix tsc config

Signed-off-by: Paul Schultz <pschultz@pobox.com>
janus-idp · Oct 22, 2024 · b261627 · b261627
1 parent b64202f
commit b261627
Show file tree

Hide file tree

Showing 47 changed files with 136 additions and 125 deletions.
diff --git a/dynamic-plugins/wrappers/backstage-plugin-techdocs/.eslintrc.js b/dynamic-plugins/wrappers/backstage-plugin-techdocs/.eslintrc.js
@@ -1 +1,12 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+const backstageConfig = require('@backstage/cli/config/eslint-factory')(
+  __dirname,
+);
+
+module.exports = {
+  ...backstageConfig,
+  rules: {
+    ...backstageConfig.rules,
+    'react/react-in-jsx-scope': 'off',
+    'react/jsx-uses-react': 'off',
+  },
+};
diff --git a/dynamic-plugins/wrappers/backstage-plugin-techdocs/src/wrapped.tsx b/dynamic-plugins/wrappers/backstage-plugin-techdocs/src/wrapped.tsx
@@ -1,19 +1,18 @@
-import React from 'react';
-import { ReportIssue } from '@backstage/plugin-techdocs-module-addons-contrib';
-import { TechDocsAddons } from '@backstage/plugin-techdocs-react';
 import {
-  TechDocsReaderPage as TechDocsReaderPageBase,
   EntityTechdocsContent as EntityTechdocsContentBase,
-} from '@backstage/plugin-techdocs';
+  TechDocsReaderPage as TechDocsReaderPageBase,
+} from "@backstage/plugin-techdocs";
+import { ReportIssue } from "@backstage/plugin-techdocs-module-addons-contrib";
+import { TechDocsAddons } from "@backstage/plugin-techdocs-react";
 
-import { SearchFilter, useSearch } from '@backstage/plugin-search-react';
+import { SearchFilter, useSearch } from "@backstage/plugin-search-react";
 
 import {
   CATALOG_FILTER_EXISTS,
   catalogApiRef,
-} from '@backstage/plugin-catalog-react';
+} from "@backstage/plugin-catalog-react";
 
-import { useApi } from '@backstage/core-plugin-api';
+import { useApi } from "@backstage/core-plugin-api";
 
 export const TechDocsReaderPage = {
   element: TechDocsReaderPageBase,
@@ -37,7 +36,7 @@ export const TechdocsSearchFilter = () => {
   const { types } = useSearch();
   const catalogApi = useApi(catalogApiRef);
 
-  if (!types.includes('techdocs')) {
+  if (!types.includes("techdocs")) {
     return null;
   }
 
@@ -48,13 +47,13 @@ export const TechdocsSearchFilter = () => {
       values={async () => {
         // Return a list of entities which are documented.
         const { items } = await catalogApi.getEntities({
-          fields: ['metadata.name'],
+          fields: ["metadata.name"],
           filter: {
-            'metadata.annotations.backstage.io/techdocs-ref':
+            "metadata.annotations.backstage.io/techdocs-ref":
               CATALOG_FILTER_EXISTS,
           },
         });
-        return items.map(entity => entity.metadata.name).sort();
+        return items.map((entity) => entity.metadata.name).sort();
       }}
     />
   );
@@ -63,5 +62,5 @@ export const TechdocsSearchFilter = () => {
 export const techdocsSearchType = (name: string, icon: React.ReactNode) => ({
   name,
   icon,
-  value: 'techdocs',
+  value: "techdocs",
 });
diff --git a/packages/app/.eslintrc.js b/packages/app/.eslintrc.js
@@ -1 +1,12 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+const backstageConfig = require('@backstage/cli/config/eslint-factory')(
+  __dirname,
+);
+
+module.exports = {
+  ...backstageConfig,
+  rules: {
+    ...backstageConfig.rules,
+    'react/react-in-jsx-scope': 'off',
+    'react/jsx-uses-react': 'off',
+  },
+};
diff --git a/packages/app/src/App.test.tsx b/packages/app/src/App.test.tsx
@@ -1,12 +1,12 @@
-import React from 'react';
+import { lazy, Suspense } from 'react';
 
 import { removeScalprum } from '@scalprum/core';
 import { mockPluginData } from '@scalprum/react-test-utils';
 import { render, waitFor } from '@testing-library/react';
 
 import TestRoot from './utils/test/TestRoot';
 
-const AppBase = React.lazy(() => import('./components/AppBase'));
+const AppBase = lazy(() => import('./components/AppBase'));
 
 describe('App', () => {
   beforeEach(() => {
@@ -31,9 +31,9 @@ describe('App', () => {
     const rendered = render(
       <TestScalprumProvider>
         <TestRoot>
-          <React.Suspense fallback={null}>
+          <Suspense fallback={null}>
             <AppBase />
-          </React.Suspense>
+          </Suspense>
         </TestRoot>
       </TestScalprumProvider>,
     );

diff --git a/packages/app/src/App.tsx b/packages/app/src/App.tsx
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import { apis } from './apis';
 import { StaticPlugins } from './components/DynamicRoot/DynamicRoot';
 import ScalprumRoot from './components/DynamicRoot/ScalprumRoot';

diff --git a/packages/app/src/bootstrap.tsx b/packages/app/src/bootstrap.tsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import ReactDOM from 'react-dom/client';
 
 import App from './App';

diff --git a/packages/app/src/common.tsx b/packages/app/src/common.tsx
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import { CodeSnippet, WarningPanel } from '@backstage/core-components';
 
 export const fetcher: <T>(...args: Parameters<typeof fetch>) => Promise<T[]> = <

diff --git a/packages/app/src/components/DynamicRoot/Loader.tsx b/packages/app/src/components/DynamicRoot/Loader.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import Box from '@mui/material/Box';
 import CircularProgress from '@mui/material/CircularProgress';

diff --git a/packages/app/src/components/DynamicRoot/ScalprumRoot.tsx b/packages/app/src/components/DynamicRoot/ScalprumRoot.tsx
@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-shadow */
 
-import React from 'react';
+
 import useAsync from 'react-use/lib/useAsync';
 
 import { AppConfig } from '@backstage/config';

diff --git a/packages/app/src/components/DynamicRoot/defaultAppComponents.tsx b/packages/app/src/components/DynamicRoot/defaultAppComponents.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { AppComponents } from '@backstage/core-plugin-api';
 

diff --git a/packages/app/src/components/Root/LogoFull.tsx b/packages/app/src/components/Root/LogoFull.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { styled } from '@mui/material/styles';
 

diff --git a/packages/app/src/components/Root/LogoIcon.tsx b/packages/app/src/components/Root/LogoIcon.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { styled } from '@mui/material/styles';
 

diff --git a/packages/app/src/components/Root/MenuIcon.tsx b/packages/app/src/components/Root/MenuIcon.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { useApp } from '@backstage/core-plugin-api';
 

diff --git a/packages/app/src/components/Root/SidebarLogo.test.tsx b/packages/app/src/components/Root/SidebarLogo.test.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 import { BrowserRouter } from 'react-router-dom';
 
 import { useSidebarOpenState } from '@backstage/core-components';

diff --git a/packages/app/src/components/Root/SidebarLogo.tsx b/packages/app/src/components/Root/SidebarLogo.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { Link, useSidebarOpenState } from '@backstage/core-components';
 import { configApiRef, useApi } from '@backstage/core-plugin-api';

diff --git a/packages/app/src/components/SignInPage/SignInPage.tsx b/packages/app/src/components/SignInPage/SignInPage.tsx
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import {
   SignInPage as CCSignInPage,
   ProxiedSignInPage,

diff --git a/packages/app/src/components/UserSettings/GeneralPage.tsx b/packages/app/src/components/UserSettings/GeneralPage.tsx
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import {
   UserSettingsAppearanceCard,
   UserSettingsIdentityCard,

diff --git a/packages/app/src/components/UserSettings/InfoCard.tsx b/packages/app/src/components/UserSettings/InfoCard.tsx
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import { InfoCard as BSInfoCard } from '@backstage/core-components';
 
 import Grid from '@mui/material/Grid';

diff --git a/packages/app/src/components/UserSettings/SettingsPages.tsx b/packages/app/src/components/UserSettings/SettingsPages.tsx
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import {
   SettingsLayout,
   UserSettingsAuthProviders,

diff --git a/packages/app/src/components/catalog/EntityPage/ApiTabContent.tsx b/packages/app/src/components/catalog/EntityPage/ApiTabContent.tsx
@@ -1,8 +1,8 @@
-import React from 'react';
+
 
 import {
-  EntityConsumedApisCard,
-  EntityProvidedApisCard,
+    EntityConsumedApisCard,
+    EntityProvidedApisCard,
 } from '@backstage/plugin-api-docs';
 import { EntitySwitch, isKind } from '@backstage/plugin-catalog';
 

diff --git a/packages/app/src/components/catalog/EntityPage/DefinitionTabContent.tsx b/packages/app/src/components/catalog/EntityPage/DefinitionTabContent.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { EntityApiDefinitionCard } from '@backstage/plugin-api-docs';
 import { EntitySwitch, isKind } from '@backstage/plugin-catalog';

diff --git a/packages/app/src/components/catalog/EntityPage/DependenciesTabContent.tsx b/packages/app/src/components/catalog/EntityPage/DependenciesTabContent.tsx
@@ -1,19 +1,19 @@
-import React from 'react';
+
 
 import {
-  EntityConsumedApisCard,
-  EntityProvidedApisCard,
+    EntityConsumedApisCard,
+    EntityProvidedApisCard,
 } from '@backstage/plugin-api-docs';
 import {
-  EntityDependsOnComponentsCard,
-  EntityDependsOnResourcesCard,
-  EntityHasSubcomponentsCard,
-  EntitySwitch,
-  isKind,
+    EntityDependsOnComponentsCard,
+    EntityDependsOnResourcesCard,
+    EntityHasSubcomponentsCard,
+    EntitySwitch,
+    isKind,
 } from '@backstage/plugin-catalog';
 import {
-  Direction,
-  EntityCatalogGraphCard,
+    Direction,
+    EntityCatalogGraphCard,
 } from '@backstage/plugin-catalog-graph';
 
 import Grid from '../Grid';

diff --git a/packages/app/src/components/catalog/EntityPage/DiagramTabContent.tsx b/packages/app/src/components/catalog/EntityPage/DiagramTabContent.tsx
@@ -1,19 +1,19 @@
-import React from 'react';
+
 
 import {
-  RELATION_API_CONSUMED_BY,
-  RELATION_API_PROVIDED_BY,
-  RELATION_CONSUMES_API,
-  RELATION_DEPENDENCY_OF,
-  RELATION_DEPENDS_ON,
-  RELATION_HAS_PART,
-  RELATION_PART_OF,
-  RELATION_PROVIDES_API,
+    RELATION_API_CONSUMED_BY,
+    RELATION_API_PROVIDED_BY,
+    RELATION_CONSUMES_API,
+    RELATION_DEPENDENCY_OF,
+    RELATION_DEPENDS_ON,
+    RELATION_HAS_PART,
+    RELATION_PART_OF,
+    RELATION_PROVIDES_API,
 } from '@backstage/catalog-model';
 import { EntitySwitch, isKind } from '@backstage/plugin-catalog';
 import {
-  Direction,
-  EntityCatalogGraphCard,
+    Direction,
+    EntityCatalogGraphCard,
 } from '@backstage/plugin-catalog-graph';
 
 import Grid from '../Grid';

diff --git a/packages/app/src/components/catalog/EntityPage/DynamicEntityTab.tsx b/packages/app/src/components/catalog/EntityPage/DynamicEntityTab.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { Entity } from '@backstage/catalog-model';
 import { ApiHolder } from '@backstage/core-plugin-api';

diff --git a/packages/app/src/components/catalog/EntityPage/EntityPage.tsx b/packages/app/src/components/catalog/EntityPage/EntityPage.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { ContextMenuAwareEntityLayout } from './ContextMenuAwareEntityLayout';
 import { defaultTabs, tabChildren, tabRules } from './defaultTabs';

diff --git a/packages/app/src/components/catalog/EntityPage/OverviewTabContent.tsx b/packages/app/src/components/catalog/EntityPage/OverviewTabContent.tsx
@@ -1,31 +1,31 @@
-import React from 'react';
+
 
 import {
-  EntityConsumingComponentsCard,
-  EntityHasApisCard,
-  EntityProvidingComponentsCard,
+    EntityConsumingComponentsCard,
+    EntityHasApisCard,
+    EntityProvidingComponentsCard,
 } from '@backstage/plugin-api-docs';
 import {
-  EntityAboutCard,
-  EntityHasComponentsCard,
-  EntityHasResourcesCard,
-  EntityHasSystemsCard,
-  EntityLinksCard,
-  EntityOrphanWarning,
-  EntityProcessingErrorsPanel,
-  EntityRelationWarning,
-  EntitySwitch,
-  hasCatalogProcessingErrors,
-  hasRelationWarnings,
-  isKind,
-  isOrphan,
+    EntityAboutCard,
+    EntityHasComponentsCard,
+    EntityHasResourcesCard,
+    EntityHasSystemsCard,
+    EntityLinksCard,
+    EntityOrphanWarning,
+    EntityProcessingErrorsPanel,
+    EntityRelationWarning,
+    EntitySwitch,
+    hasCatalogProcessingErrors,
+    hasRelationWarnings,
+    isKind,
+    isOrphan,
 } from '@backstage/plugin-catalog';
 import { EntityCatalogGraphCard } from '@backstage/plugin-catalog-graph';
 import {
-  EntityGroupProfileCard,
-  EntityMembersListCard,
-  EntityOwnershipCard,
-  EntityUserProfileCard,
+    EntityGroupProfileCard,
+    EntityMembersListCard,
+    EntityOwnershipCard,
+    EntityUserProfileCard,
 } from '@backstage/plugin-org';
 
 import Grid from '../Grid';

diff --git a/packages/app/src/components/catalog/EntityPage/defaultTabs.tsx b/packages/app/src/components/catalog/EntityPage/defaultTabs.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { Entity } from '@backstage/catalog-model';
 import { isKind } from '@backstage/plugin-catalog';

diff --git a/packages/app/src/components/catalog/Grid/Grid.tsx b/packages/app/src/components/catalog/Grid/Grid.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import Box, { BoxProps } from '@mui/material/Box';
 import { makeStyles } from 'tss-react/mui';

diff --git a/packages/app/src/components/learningPaths/LearningPathsPage.tsx b/packages/app/src/components/learningPaths/LearningPathsPage.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { Content, Header, InfoCard, Page } from '@backstage/core-components';
 import { SearchContextProvider } from '@backstage/plugin-search-react';

diff --git a/packages/app/src/components/search/SearchPage.tsx b/packages/app/src/components/search/SearchPage.tsx
@@ -1,5 +1,3 @@
-import React from 'react';
-
 import { CatalogIcon, Content, Header, Page } from '@backstage/core-components';
 import { CatalogSearchResultListItem } from '@backstage/plugin-catalog';
 import { SearchType } from '@backstage/plugin-search';

diff --git a/plugins/dynamic-home-page/.eslintrc.js b/plugins/dynamic-home-page/.eslintrc.js
@@ -1 +1,12 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+const backstageConfig = require('@backstage/cli/config/eslint-factory')(
+  __dirname,
+);
+
+module.exports = {
+  ...backstageConfig,
+  rules: {
+    ...backstageConfig.rules,
+    'react/react-in-jsx-scope': 'off',
+    'react/jsx-uses-react': 'off',
+  },
+};
diff --git a/plugins/dynamic-home-page/dev/index.tsx b/plugins/dynamic-home-page/dev/index.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+
 
 import { createDevApp, DevAppPageOptions } from '@backstage/dev-utils';
 import {