Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD Overview and History Cards render when argocd annotation doesn't exist #650

Closed
Zaperex opened this issue Oct 23, 2023 · 1 comment
Assignees
Labels
kind/bug Something isn't working status/ready

Comments

@Zaperex
Copy link
Member

Zaperex commented Oct 23, 2023

Describe the bug

ArgoCD Overview Card (in Overview tab) and ArgoCD History Card (in CD tab) appear even when the argocd annotations don't exist in the catalog-info.yaml of the component.
image
image

Expected Behavior

The ArgoCD Overview and History Cards (Since CD tab is just the history card, it shouldn't appear either) should conditionally render depending on whether the argocd annotation exists for the component
image

What are the steps to reproduce this bug?

  1. Have a component entity registered into the catalog
  2. Make sure component has no argocd annotations, and has spec.type as either website or service
  3. Observe Missing Annotation error cards in place of argocd overview and history card
@Zaperex Zaperex added kind/bug Something isn't working status/triage labels Oct 23, 2023
@Zaperex Zaperex self-assigned this Oct 23, 2023
@Zaperex Zaperex changed the title ArgoCD Overview and History Cards appear when argocd annotation doesn't exist ArgoCD Overview and History Cards render when argocd annotation doesn't exist Nov 3, 2023
@Zaperex
Copy link
Member Author

Zaperex commented Nov 8, 2023

Solved by #700

@Zaperex Zaperex closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working status/ready
Projects
None yet
2 participants