-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enabled conditional rendering for the ArgoCD overview and history cards #651
Conversation
🦋 Changeset detectedLatest commit: 803c997 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The image is available at: |
@Zaperex has |
I'm not sure what was wrong with it to begin with, since it was working when I tested it with the presence of |
@christophe-f do you remember why |
I believe that was a bug in the plugin. It could have been fixed since then. |
The image is available at: |
The image is available at: |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The image is available at: |
This is solved by #700 backstage-showcase/dynamic-plugins.default.yaml Lines 276 to 291 in 7ed4465
@Zaperex can we close this? WDYT? |
Yep it makes sense to close this issue now |
Description
Enabled conditional rendering for the ArgoCD overview and history cards based on presence of an argocd annotation
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer