Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enabled conditional rendering for the ArgoCD overview and history cards #651

Closed
wants to merge 5 commits into from

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Oct 23, 2023

Description

Enabled conditional rendering for the ArgoCD overview and history cards based on presence of an argocd annotation

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Zaperex Zaperex requested a review from a team as a code owner October 23, 2023 21:16
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 803c997

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-651!

@schultzp2020
Copy link
Member

@Zaperex has isArgocdAvailable been fixed?

@Zaperex
Copy link
Member Author

Zaperex commented Oct 24, 2023

I'm not sure what was wrong with it to begin with, since it was working when I tested it with the presence of argocd/app-name in the entity's annotations.

@schultzp2020
Copy link
Member

@christophe-f do you remember why isArgocdAvailable wasn't working?

@christophe-f
Copy link
Contributor

@christophe-f do you remember why isArgocdAvailable wasn't working?

I believe that was a bug in the plugin. It could have been fixed since then.

@github-actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-651!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-651!

Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-651!

@tumido
Copy link
Member

tumido commented Nov 8, 2023

This is solved by #700

- mountPoint: entity.page.overview/cards
importName: EntityArgoCDOverviewCard
config:
layout:
gridColumn: "1 / span 8"
if:
allOf:
- isArgocdAvailable
- mountPoint: entity.page.cd/cards
importName: EntityArgoCDHistoryCard
config:
layout:
gridColumn: "1 / -1"
if:
allOf:
- isArgocdAvailable

@Zaperex can we close this? WDYT?

@Zaperex
Copy link
Member Author

Zaperex commented Nov 8, 2023

Yep it makes sense to close this issue now

@Zaperex Zaperex closed this Nov 8, 2023
@Zaperex Zaperex deleted the update-argocd-components branch November 8, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD Overview and History Cards render when argocd annotation doesn't exist
5 participants