Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekton plugin should be shown only on CI tab and not dedicated Tekton tab #718

Closed
invincibleJai opened this issue Nov 6, 2023 · 3 comments · Fixed by #749
Closed

Tekton plugin should be shown only on CI tab and not dedicated Tekton tab #718

invincibleJai opened this issue Nov 6, 2023 · 3 comments · Fixed by #749
Assignees
Labels

Comments

@invincibleJai
Copy link
Member

Describe the bug

Tekton plugin should be shown only on CI tab and not dedicated Tekton tab if entity has annotations janus-idp.io/tekton : <entity_name>

Expected Behavior

PLR list should only be shown CI tab and not Tekton tab

What are the steps to reproduce this bug?

  1. Go to the janus-IDP instance
  2. Install and configure tekton plugin
  3. add/register an entity https://github.com/invincibleJai/nationalparks-py/blob/master/catalog-info.yaml
  4. Check CI tab / look for tekton tab

Versions of software used and environment

@invincibleJai invincibleJai added kind/bug Something isn't working status/triage labels Nov 6, 2023
@invincibleJai
Copy link
Member Author

with dynamic plugin this should be handled #700

@kadel kadel added the post-FF label Nov 8, 2023
@kadel
Copy link
Member

kadel commented Nov 8, 2023

task: verify that #700 fixes this

@invincibleJai
Copy link
Member Author

task: verify that #700 fixes this

No it doesn't and we need to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants